In life, vanity is good, but only if the vanity is deep. Shallow and superficial vanity is a detractor and a distraction.
For example, pride in one’s possessions is a very superficial form of vanity. A better source of vanity is the vanity you get from your artworks, your character, or your own personal innovations.
Pride in your physical strength is a good thing. Also pride in your personal courage.